Consistent option names pt1 #2314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ompatibility-clause to support the old name as well
…tension for a specific dataset)
Contributor
|
Looking good! |
Contributor
Author
|
Glad to hear. Working on doing the same for the point-options now |
Member
|
Looks good |
…Radius" and "pointHitRadius"
…ius" to "pointHitRadius", adding compatibility-clauses to support the old names as well
Contributor
Author
|
Allright, I just pushed part 2 but kept the branch name so it goes into this PR. |
Contributor
Author
|
And just to have a reference: fixes #2307 |
Member
|
@tannerlinsley feel free to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, first changeset, changing only tension -> lineTension. Feel free to comment on stuff you don't like.