Skip to content

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented May 7, 2016

File size reductions in Controller.Doughnut.js, element.point.js, and core.title.js

Removed the unnecessary stuff from #2470

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 75.227% when pulling cf5c75e on file-size-reduction into 51d8a5b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 75.212% when pulling 9d832cc on file-size-reduction into 51d8a5b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 75.211% when pulling 1668010 on file-size-reduction into 51d8a5b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 75.218% when pulling 33d1037 on file-size-reduction into 51d8a5b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.357% when pulling e86a13d on file-size-reduction into 51d8a5b on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.508% when pulling ee383ef on file-size-reduction into 51d8a5b on master.

@fulldecent
Copy link
Contributor

Did you generate this automatically using any tool?

@etimberg
Copy link
Member Author

etimberg commented May 8, 2016

@fulldecent nope, its all hand done

Conflicts:
	src/controllers/controller.doughnut.js
	src/controllers/controller.polarArea.js
@etimberg
Copy link
Member Author

@zachpanz88 @simonbrunel do you think we can start merging this stuff?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.562% when pulling 1402106 on file-size-reduction into 691a7c6 on master.

@panzarino
Copy link
Contributor

Looks good to me, assuming everything still works correctly, which it seems like it does.

@etimberg etimberg merged commit c6354cf into master May 13, 2016
@etimberg etimberg deleted the file-size-reduction branch May 25, 2016 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants