-
Notifications
You must be signed in to change notification settings - Fork 12k
File size reduction #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
File size reduction #2491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore dataset controller
Contributor
|
Did you generate this automatically using any tool? |
Member
Author
|
@fulldecent nope, its all hand done |
Conflicts: src/controllers/controller.doughnut.js src/controllers/controller.polarArea.js
Member
Author
|
@zachpanz88 @simonbrunel do you think we can start merging this stuff? |
Contributor
|
Looks good to me, assuming everything still works correctly, which it seems like it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File size reductions in
Controller.Doughnut.js,element.point.js, andcore.title.jsRemoved the unnecessary stuff from #2470