Fix out of bounds index access in getLabelMoment #3039
Merged
+34
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calling getLabelMoment with an out of bound index would cause an error such as this: ``` Uncaught TypeError: Cannot read property 'null' of undefined ``` This happens because there is not always guaranteed to be a labelMoment on at the current datasetIndex. One example of this is practice comes from a this function call: ```js // since the are not always guaranteed to be at least two labelMoments // \ / this index can be out of bounds // | var tickWidth = me.getPixelForTick(1) - me.getPixelForTick(0) - 6; ``` This patch simply ensures that the `labelMoments` for the `datasetIndex` are defined before accessing properties on it.
Member
|
Thanks @ianks |
Contributor
|
BTW, this was already solved by my pull request #3024, yet still opened because of a Travis CI build timeout error... Also, with the use of the plugin Chart.Zoom, the value of |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Fix out of bounds index access in getLabelMoment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling getLabelMoment with an out of bound index would cause an
error such as this:
This happens because there is not always guaranteed to be a labelMoment on
at the current datasetIndex.
One example of this is practice comes from a this function call:
This patch simply ensures that the
labelMomentsfor thedatasetIndexaredefined before accessing properties on it.