Better animation when adding or removing data #3399
Conversation
simonbrunel
force-pushed
the
live-chart
branch
from
0801126 to
8a1b294
Compare
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
These look good. just one minor comment about the comments
src/core/core.datasetController.js
Outdated
| }, | ||
|
|
||
| /** | ||
| * private |
simonbrunel
force-pushed
the
live-chart
branch
2 times, most recently
from
35009b7 to
dae14e8
Compare
|
I am 👍 to merge this. I don't know if you prefer waiting for any other comments or not |
In order to simulate real-time chart updates (i.e. horizontal animation), it's necessary to distinguish a removed or added value from a simple update. The dataset controller now hooks array methods that alter the data array length to synchronize metadata accordingly. Also remove the duplicate calls of updateBezierControlPoints() for line and radar charts.
simonbrunel
force-pushed
the
live-chart
branch
from
dae14e8 to
2dae0a1
Compare
|
Added data cleanup (
|
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
Just the one comment on documentation. Other than that, this is good to go 👍
| } | ||
| }, | ||
|
|
||
| createMetaDataset: function() { |
There was a problem hiding this comment.
I realized this method isn't mentioned in the docs ... is that intentional? We don't document the datasetElementType and dataElementType properties either
There was a problem hiding this comment.
You right, we should document datasetElementType and dataElementType, not sure about createMetaDataset and createMetaData. That can be done in a future PR though :)
|
Can we merge this? |
2 participants
In order to simulate real-time chart updates (i.e. horizontal animation), it's necessary to distinguish a removed or added value from a simple update. The dataset controller now hooks array methods that alter the data array length to synchronize metadata accordingly. Also remove the duplicate calls of updateBezierControlPoints() for line and radar charts.
Examples: http://playground.abysscorp.org/chartjs/livecharts/
Plunker: http://plnkr.co/Imxwl9OQJuaMepLNy6ly
Related issues: #1997 #3126