Update the docs structure/content to use GitBook #3751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC @chartjs/maintainers for review |
panzarino
approved these changes
Dec 30, 2016
Member
Author
|
I should add, the folder structure of the new files is:
|
Member
|
Nice work, I would hold on before merging to have the Gitbook integration because if a new release is required before, the current doc generator will not work. About the file structure, what about naming the main file for each directory: I saw that practice quite often, that's allow to navigate in the doc directly from GH: |
Member
Author
|
I think waiting until we have gitbook integration is a good idea. Any ideas how long it might take to get working? I can change to the README.md names since I'll need to rebase anyway |
Contributor
|
I approve this pr
…On Sun, Jan 1, 2017 at 9:51 AM Evert Timberg ***@***.***> wrote:
I think waiting until we have gitbook integration is a good idea. Any
ideas how long it might take to get working? I can change to the README.md
names since I'll need to rebase anyway
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#3751 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFUmCWOj1X1IrE7DalphC-s-VYuFGZn3ks5rN-eYgaJpZM4LYZSL>
.
|
|
What doc generator is Chart.js using now? |
Member
Author
|
@Menci this doesn't change the generator. @simonbrunel is working on changing it to GitBook |
|
Hmm... I just want to make my docs so beautiful as Chart.js ...... So could
anyone tell me?
…On Sun, Jan 8, 2017 at 21:53 Evert Timberg ***@***.***> wrote:
@Menci <https://github.com/menci> this doesn't change the generator.
@simonbrunel <https://github.com/simonbrunel> is working on changing it
to GitBook
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3751 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK0Qg1BMJfcggoepnMyIEOv4xPbg8kWZks5rQOpqgaJpZM4LYZSL>
.
|
Member
|
@etimberg for consistency, we should move |
etimberg
force-pushed
the
documentation-rewrite
branch
2 times, most recently
from
4aac82a to
3815036
Compare
Member
Author
|
@simonbrunel I made the changes we discussed |
jakesylvestre
approved these changes
Jan 10, 2017
simonbrunel
force-pushed
the
documentation-rewrite
branch
from
2201e7b to
877a06a
Compare
Member
Author
|
@simonbrunel looking good. Can you fix the conflicts? Then we can start testing this out once v2.5 releases. Great job! |
etimberg
force-pushed
the
documentation-rewrite
branch
from
877a06a to
ed670d0
Compare
simonbrunel
force-pushed
the
documentation-rewrite
branch
from
094a9e9 to
f0904df
Compare
etimberg
force-pushed
the
documentation-rewrite
branch
from
2a1fd0c to
a0c48a9
Compare
simonbrunel
changed the title
simonbrunel
approved these changes
Mar 20, 2017
This was referenced Mar 21, 2017
Closed
roicos
pushed a commit
to roicos/Chart.js
that referenced
this pull request
Aug 21, 2017
Update the docs structure/content to use GitBook
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Update the docs structure/content to use GitBook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old doc files except for the comparison table.
Fixed #3547, #3490, #3118, #2043, #3274, #2362, #2325, #2386, #3299, #3237, #3549 while at it.