Chart.Controller deprecation #3839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
chart-namespace
branch
from
c77fd37 to
6ac420c
Compare
etimberg
reviewed
Jan 28, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
These look good. Will sync them and test them out
| backgroundColor: color(window.chartColors.red).alpha(0.2).rgbString(), | ||
| borderColor: window.chartColors.red, | ||
| data: [ | ||
| randomScalingFactor(), |
Member
There was a problem hiding this comment.
are these just whitespace changes?
Member
Author
There was a problem hiding this comment.
Yes, my editor is configured to remove trailing whitespace, which is actually an ESLint rule, but examples are not part of the lint process.
| }); | ||
| }); | ||
|
|
||
| describe('Version 2.1.5', function() { |
Member
There was a problem hiding this comment.
oh awesome, I was going to suggest we add this. You're one step ahead of me 😄
etimberg
approved these changes
Jan 28, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
I tested these changes out. I tried the samples for all different chart types and did not notice anything. I also tested the zoom and annotation plugins using their sample files and they still worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates
Chart.Controller(and the nestedchartproperty) by gatheringchartandchart.chartproperties at the same level (chart.chartnow being an alias tochart).chartInstancevariables have been renamed tochartsince there is no more distinction. A new test file has been added to keep track of deprecations (test/global.deprecations.tests.js).Fixes #2481