Fix issue with how Chart.PluginBase is defined #3883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
requested changes
Feb 9, 2017
src/core/core.plugin.js
Outdated
| * @private | ||
| */ | ||
| Chart.PluginBase = helpers.inherits({}); | ||
| Chart.PluginBase = function() {}; |
Member
There was a problem hiding this comment.
I think Chart.PluginBase = Chart.Element.extend({}); is more in line with the previous implementation because it calls initialize at construction time.
Member
Author
|
Updated per review comments |
simonbrunel
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3881
Tested with the Chart.Bands.js plugin.