Handle incoming model values on element transition #3960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
Feb 25, 2017
| } | ||
| } | ||
| } else if (type === 'number') { | ||
| view[key] = origin + (target - origin) * ease; |
Member
There was a problem hiding this comment.
The only thing that's lost here is the NaN check which we already discussed about.
Member
Author
There was a problem hiding this comment.
Good catch, I will add that check back!
Member
Author
There was a problem hiding this comment.
What is the case already where isNaN(foo) === true and typeof(foo) === "number"?
Edit: answer
typeof(NaN)andtypeof(Infinity)
Member
Author
There was a problem hiding this comment.
Added isFinite checks on origin and target!
If a value is set on the model after `pivot()` has been called, the view wasn't initialized and the animation started from 0. Now, `_start` and incomplete `_view` are initialized to the model value during the transition (no initial implicit transition). Also remove exception handling when animating a string (color), which is faster when string are not valid colors (e.g. tooltip position). It requires to update `chartjs-color` to version 2.1.0.
simonbrunel
force-pushed
the
transition-cleanup
branch
from
568fd4d to
043adc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a value is set on the model after
pivot()has been called, the view wasn't initialized and the animation started from 0. Now,_startand incomplete_vieware initialized to the model value during the transition (no initial implicit transition).Also remove exception handling when animating a string (color), which is faster when string are not valid colors (e.g. tooltip position). It requires to update
chartjs-colorto version 2.1.0.