Cleanup and upgrade unit tests environment #3986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
unittest_cleanup
branch
2 times, most recently
from
771367f to
cd30f72
Compare
simonbrunel
force-pushed
the
unittest_cleanup
branch
from
cd30f72 to
f8d8890
Compare
`karma.conf.ci.js` has been merged into `karma.conf.js` for local testing consistency: `gulp unittestWatch` has been replaced by `gulp unittest --watch` and thus use exactly the same config file. Upgrade to latest jasmine and karma packages and remove deprecated `gulp-karma` dependency (directly use `karma.Server` in gulp). Split `test/mockContext.js` into smaller `test/jasmine.*` modules to make easier unit tests maintenance and finally, move all `*.test.js` files under the `test/specs` folder.
simonbrunel
force-pushed
the
unittest_cleanup
branch
from
f8d8890 to
3471b7d
Compare
etimberg
approved these changes
Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
karma.conf.ci.jshas been merged intokarma.conf.jsfor local testing consistency:gulp unittestWatchhas been replaced bygulp unittest --watchand thus use exactly the same config file. Upgrade to latest jasmine and karma packages and remove deprecatedgulp-karmadependency (directly usekarma.Serverin gulp).Split
test/mockContext.jsinto smallertest/jasmine.*modules to make easier unit tests maintenance and finally, move all*.test.jsfiles under thetest/specsfolder.