Fixed calculation of scale min and max when dataset contains no values #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Do I need to extract the similar code (which was detected) to its own method? Is this condition for merge? |
Member
|
I don't think it worth the refactor since it's not really the same logic (min vs max). Can you update unit tests? |
Member
|
I agree about the unit tests. We should have tests covering these cases for the future to ensure this does not break |
Contributor
Author
|
I have added test for this scenario |
etimberg
approved these changes
Mar 28, 2017
ericnkatz
pushed a commit
to ericnkatz/Chart.js
that referenced
this pull request
May 24, 2017
chartjs#4064) * Fixed different calculation of scale min and max when dataset contains no values * Removed trailing spaces * Added test for correct min/max calculation * Removed trailing spaces
|
Maybe this patch indroduced a breakage on min scale settings using the scale type 'time'? Upgrading from 2.5 to 2.6 seems that make scales.xAxes[].min parameter ignored. |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
chartjs#4064) * Fixed different calculation of scale min and max when dataset contains no values * Removed trailing spaces * Added test for correct min/max calculation * Removed trailing spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale does not respect suggestedMin and suggestedMax when dataset contains no values.
jsfiddle: https://jsfiddle.net/o6g51gow/1/