Move easing effects in separate file + unit tests #4475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
force-pushed
the
helpers-easing
branch
from
a95da17 to
6cdd6d0
Compare
etimberg
reviewed
Jul 8, 2017
Member
etimberg
left a comment
etimberg
left a comment
There was a problem hiding this comment.
A few minor comments. Other than that, it looks good 👍
| }, | ||
|
|
||
| easeInExpo: function(t) { | ||
| return (t === 0) ? 0 : Math.pow(2, 10 * (t - 1)); |
Member
There was a problem hiding this comment.
I think this changed when t === 0. Was that intentional? The old version was
easeInExpo: function(t) {
return (t === 0) ? 1 : 1 * Math.pow(2, 10 * (t / 1 - 1));
}
Member
Author
There was a problem hiding this comment.
I think it was incorrectly adapted from the original method:
// t: current time, b: start value, c: end value, d: duration
easeInExpo: function (x, t, b, c, d) {
return (t==0) ? b : c * Math.pow(2, 10 * (t/d - 1)) + b;
}All these methods assume b == 0 and c == 1 and d == 1
src/helpers/helpers.easing.js
Outdated
| return 1; | ||
| } | ||
| if (!p) { | ||
| p = 1 * 0.3; |
Member
There was a problem hiding this comment.
could we simplify this too as p = 0.3?
src/helpers/helpers.easing.js
Outdated
| if (!p) { | ||
| p = 1 * 0.3; | ||
| } | ||
| if (a < Math.abs(1)) { |
Member
There was a problem hiding this comment.
Could also remove Math.abs(1) too
src/helpers/helpers.easing.js
Outdated
| return 1; | ||
| } | ||
| if (!p) { | ||
| p = 1 * 0.3; |
src/helpers/helpers.easing.js
Outdated
| if (!p) { | ||
| p = 1 * 0.3; | ||
| } | ||
| if (a < Math.abs(1)) { |
src/helpers/helpers.easing.js
Outdated
| return 1; | ||
| } | ||
| if (!p) { | ||
| p = 0.3 * 1.5; |
Member
There was a problem hiding this comment.
could we change this to p = 0.45 ?
src/helpers/helpers.easing.js
Outdated
| if (!p) { | ||
| p = 0.3 * 1.5; | ||
| } | ||
| if (a < Math.abs(1)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed
1*,/1and replace1/2by0.5