Skip to content

Conversation

@benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 24, 2017

I thought it would be useful to have an example with distribution: series since it's such a major feature. I also thought this was a nice showcase as it's semi-realistic looking

As a developer, I find this sample helpful to test with sometimes because it has more data points than the current samples. Also, there are a lot of cases where it's really nice to have a sample that shows time scale with bar chart since we've gotten a lot of bug reports about that use case

Here's a screenshot:

screenshot from 2017-09-07 08-45-13

And with the bar chart option selected:

screenshot from 2017-09-07 08-47-07

@andig
Copy link
Contributor

andig commented Aug 12, 2017

@etimberg I'd be happy to contribute a mixed bar over category/ line over time chart if you need one for testing. It would currently be broken though.

@benmccann benmccann mentioned this pull request Sep 5, 2017
4 tasks
@andig
Copy link
Contributor

andig commented Sep 5, 2017

@benmccann it took me some time to understand how/ what this actually achieves. I‘d suggest to somehow document that the use case here is to create a non-linear time axis that is e.g. Suitable for omitting non-workdays.

I‘m still wondering how good this approach is since it still requires equally-spaced data. Drawing e.g. Hourly values over a month would not be possible, neither would be sparse data series.

Am I missing something?

@benmccann benmccann force-pushed the sample branch 2 times, most recently from 1dfa97b to 701e57c Compare September 7, 2017 15:23
@benmccann
Copy link
Contributor Author

I'm not sure why you say that drawing hourly values over a month would not be possible.

It seems like your questions are about whether the series mode makes sense and not about the sample specifically. I think it'd confuse things to have that discussion on this PR since it's not directly related. Maybe we can continue the conversation on Slack instead?

@andig
Copy link
Contributor

andig commented Sep 8, 2017

I think it'd confuse things to have that discussion on this PR since it's not directly related.

Sorry if I've picked the wrong place. I'll contact you on slack.

@simonbrunel simonbrunel added this to the Version 2.7 milestone Sep 9, 2017
<head>
<title>Line Chart</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.18.1/moment.min.js"></script>
<script src="../../../dist/Chart.js"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benmccann can you use Chart.bundle.js instead and remove the cdnjs.cloudflare.com dependency, like that the example can be open locally / offline from the ZIP archive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't work unfortunately. It results in Uncaught ReferenceError: moment is not defined. These couple lines are in the other time samples as well

@simonbrunel simonbrunel merged commit fb4357e into chartjs:master Sep 10, 2017
yofreke pushed a commit to yofreke/Chart.js that referenced this pull request Dec 30, 2017
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants