-
Notifications
You must be signed in to change notification settings - Fork 12k
Add a financial time series sample #4554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b48fb92 to
aff975d
Compare
|
@etimberg I'd be happy to contribute a mixed bar over category/ line over time chart if you need one for testing. It would currently be broken though. |
|
@benmccann it took me some time to understand how/ what this actually achieves. I‘d suggest to somehow document that the use case here is to create a non-linear time axis that is e.g. Suitable for omitting non-workdays. I‘m still wondering how good this approach is since it still requires equally-spaced data. Drawing e.g. Hourly values over a month would not be possible, neither would be sparse data series. Am I missing something? |
1dfa97b to
701e57c
Compare
|
I'm not sure why you say that drawing hourly values over a month would not be possible. It seems like your questions are about whether the |
Sorry if I've picked the wrong place. I'll contact you on slack. |
| <head> | ||
| <title>Line Chart</title> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.18.1/moment.min.js"></script> | ||
| <script src="../../../dist/Chart.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benmccann can you use Chart.bundle.js instead and remove the cdnjs.cloudflare.com dependency, like that the example can be open locally / offline from the ZIP archive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work unfortunately. It results in Uncaught ReferenceError: moment is not defined. These couple lines are in the other time samples as well
I thought it would be useful to have an example with
distribution: seriessince it's such a major feature. I also thought this was a nice showcase as it's semi-realistic lookingAs a developer, I find this sample helpful to test with sometimes because it has more data points than the current samples. Also, there are a lot of cases where it's really nice to have a sample that shows time scale with bar chart since we've gotten a lot of bug reports about that use case
Here's a screenshot:
And with the bar chart option selected: