Update custom tooltip documentation and samples #5166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
reviewed
Jan 21, 2018
| tooltipEl.style.fontSize = tooltip.fontSize; | ||
| tooltipEl.style.fontStyle = tooltip._fontStyle; | ||
| tooltipEl.style.fontFamily = tooltip._bodyFontFamily; | ||
| tooltipEl.style.fontSize = tooltip.bodyFontSize + 'px'; |
Member
There was a problem hiding this comment.
Is it bodyFontSize or _bodyFontSize?
Member
There was a problem hiding this comment.
Looks like it's bodyFontSize but it's weird the other properties are marked private
Member
Author
There was a problem hiding this comment.
yeah, not entirely sure why that is :|
Member
Author
There was a problem hiding this comment.
actually, I know .... properties that start with _ aren't animated so the strings don't need to transition, but other stuff does
simonbrunel
approved these changes
Jan 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5122