Skip to content

Account for floating point error in niceNum helper #9343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2021
Merged

Account for floating point error in niceNum helper #9343

merged 2 commits into from
Jul 1, 2021
+28 −1

Conversation

@etimberg
Copy link
Member

@etimberg etimberg commented Jul 1, 2021

Resolves #9334

@etimberg etimberg added this to the Version 3.4.1 milestone Jul 1, 2021
kurkle
kurkle previously approved these changes Jul 1, 2021
View reviewed changes
@etimberg etimberg merged commit fea3f20 into chartjs:master Jul 1, 2021
@etimberg etimberg deleted the step-size-float-math branch July 1, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurkle kurkle kurkle approved these changes

Assignees

No one assigned

Labels

type: bug

Projects

None yet

Milestone

Version 3.4.1

Development

Successfully merging this pull request may close these issues.

Problems with ticks and floating point stepSize

2 participants

@etimberg @kurkle