Implement moment diff cache in time scale #3261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces number of calls to momentjs diff() if there are multiple datasets sharing the same labels (chartjs#3211).
Previously buildLabelDiffs() was called at the end of buildTicks() and hence labelDiffs cache was calculated twice (in getMinimumBoxSize() and then in fitBox()).
|
I think this is fine to merge |
Use '!==' instead of '!='. This fixes eqeqeq error reported by gulp-eslint.
|
@simonbrunel @zachpanz88 is this good to merge? |
|
Looks good to me |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Implement moment diff cache in time scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the performance as described in #3211 without the need to refactor the code.