Add Label Badge to Line Chart. #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 8, 2016 14:06
Fixes an inconsistency between the "configuration" section and the "line annotations" section, where config section had value in single quotes and line annotation section has it as a number.
… doesn't overlap data.
Made it so the badge is drawn conditionally, so that if you don't have a label, it doesn't show up, to avoid an null label badge. Added a todo comment about what I would like to do with this eventually.
| }, | ||
|
|
||
| afterDraw: function(chartInstance, easingDecimal) { | ||
| beforeDraw: function(chartInstance, easingDecimal) { |
Member
There was a problem hiding this comment.
probably should be beforeDatasetsDraw per my comment in the other issue
| if (options.label) { | ||
| //draw the background of the badge. | ||
| ctx.fillStyle = 'white'; | ||
| ctx.fillRect((chartArea.right / 2), pixel - 5, 35, 15); |
Member
There was a problem hiding this comment.
Sorry that this took a while. I went to merge this and do some testing and I noticed this is incorrect. The width of the fill rect should be the width of the text. The text can be measured using ctx.measureText. To use this effectively, the font should be configurable and would need to be set before calling measureText.
The height of the rect would be the font size in px.
Collaborator
|
It doesn't appear that this works correctly with vertical lines yet. |
petewalker
pushed a commit
to petewalker/chartjs-plugin-annotation
that referenced
this pull request
Oct 18, 2016
Originally based on chartjs#12. Added an optional Label option to Line Annotation. Updated the documentation to display this. Also added a sample showing how it can work.
Contributor
|
I've added a follow-up to this pull request that addresses the configurability issues, and the compatibility with vertical lines: #31 |
petewalker
pushed a commit
to petewalker/chartjs-plugin-annotation
that referenced
this pull request
Oct 19, 2016
Originally based on chartjs#12. Added an optional Label option to Line Annotation. Updated the documentation to display this. Also added a sample showing how it can work.
Collaborator
petewalker
pushed a commit
to petewalker/chartjs-plugin-annotation
that referenced
this pull request
Nov 4, 2016
Originally based on chartjs#12. Added an optional Label option to Line Annotation. Updated the documentation to display this. Also added a sample showing how it can work.
compwright
pushed a commit
that referenced
this pull request
Nov 15, 2016
* Added tooltip label to line chart Originally based on #12. Added an optional Label option to Line Annotation. Updated the documentation to display this. Also added a sample showing how it can work. * Fixed calculations as per comments Moved rendering calculations to lineUpdate function, also fixed a minor reference bug that prevented animations from working at all. * Fixed font bug introduced by last commit * Fixed sample post-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional Label option to Line Annotation.
Updated the documentation to display this.