Refactor MimeFactory #2233
Merged
Refactor MimeFactory #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
mimefactory-refactor
branch
from
77b6f36 to
d5349c8
Compare
This will allow MimeFactory.render() to put protected headers into main_part and wrap it into single-part multipart/mixed if protected headers are too large to put into the outermost IMF.
Passing Context around explicitly removes the need for explicit lifetimes.
r10s
approved these changes
Feb 14, 2021
Contributor
r10s
left a comment
r10s
left a comment
There was a problem hiding this comment.
lgtm, thanks for cleaning up'a!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of lifetimes and move message building to the end of MimeFactory.render()
This is the first part of #2232