api: jsonrpc: typescript remove unused constants #7355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `DC_CERTCK_*`, `DC_SOCKET_*`, `DC_LP_AUTH_*` are not used anymore, `EnteredLoginParam` has their own representations for these values which are not number based. - `DC_PUSH_*` the api returning that is not yet part of jsonrpc and when it will be, then it will return an enum/string-union anyways - `DC_TEXT1_*` the type is not returned by the jsonrpc api
Simon-Laux
commented
Oct 26, 2025
Comment on lines
+44
to
+46
| key.startsWith("DC_CERTCK_") || | ||
| key.startsWith("DC_SOCKET_") || | ||
| key.startsWith("DC_LP_AUTH_") || |
Contributor
Author
There was a problem hiding this comment.
I guess we could also mark them as deprecated first?
I think it is still possible to configure an account via set config and configure?
(will be replaced by add_transport eventually)
link2xt
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DC_CERTCK_*,DC_SOCKET_*,DC_LP_AUTH_*are not used anymore,EnteredLoginParamhas their own representations for these values whichare not number based.
DC_PUSH_*the api returning that is not yetpart of jsonrpc and when it will be, then it will return an
enum/string-union anyways
DC_TEXT1_*the type is not returned by thejsonrpc api