Test background_fetch #7448
Merged
Test background_fetch #7448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/test-background-fetch
branch
2 times, most recently
from
2f2a0a5 to
a9af4e4
Compare
link2xt
force-pushed
the
link2xt/test-background-fetch
branch
from
a9af4e4 to
8221914
Compare
Simon-Laux
approved these changes
Nov 15, 2025
iequidoo
reviewed
Nov 16, 2025
| # Stopping background fetch immediately after starting | ||
| # does not result in any errors. | ||
| background_fetch_future = dc.background_fetch.future(300) | ||
| dc.stop_background_fetch() |
Collaborator
There was a problem hiding this comment.
Is this reliable? Core's stop_background_fetch() does nothing if background_fetch_interrupt_sender is None. Maybe sleep for a second before stopping?
Collaborator
Author
There was a problem hiding this comment.
If we sleep for a second, then maybe background fetch has already stopped. I don't know how to test stop_background_fetch(), so did something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7447