re-enable running the CI in pull requests, but not concurrently#258
Merged
re-enable running the CI in pull requests, but not concurrently#258
Conversation
missytake
changed the title
Contributor
Author
|
The CI fails because of #217 |
missytake
changed the title
Otherwise packages may add user without correct configuration such as groups and the step adding user will be skipped.
Contributor
|
Failure is not related do opendkim, postfix log starts like this: The problem is that We need to ensure somehow that Dovecot creates socket before we start Postfix. We can try to create |
Contributor
|
Works after reordering Dovecot before Postfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #246
Fix #217
I documented the sysadmin side in https://github.com/deltachat/sysadmin/commit/b1fbedc2fd5982d58584a5c6499368018ca68ee1
It would be nice if we could make sure that the offline tests and formatting checks don't make the CI stop if they fail; because then it doesn't get to the step where it can restore the ACME and DKIM state, and we lose some private certs on the server.