metadata: add support for /shared/vendor/deltachat/irohrelay#284
Merged
metadata: add support for /shared/vendor/deltachat/irohrelay#284
Conversation
link2xt
force-pushed
the
link2xt/iroh-relay
branch
4 times, most recently
from
a170024 to
390821b
Compare
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
390821b to
b66c3d5
Compare
3 tasks
hpk42
reviewed
May 6, 2024
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
looks good but better add a test to test_metadata.py -- currently only the iroh_relay == None path is tested. and it would be good to see the metadata keys spelled out.
hpk42
approved these changes
May 6, 2024
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
to be clear: i am fine to merge it but prefer there to be a test.
Contributor
Author
|
Does not have to be merged immediately, we have a testing setup on c2 that can be used already. |
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
b66c3d5 to
e9e5651
Compare
link2xt
force-pushed
the
link2xt/iroh-relay
branch
from
e9e5651 to
94f39ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for peerchannels: chatmail/core#5346