filtermail: do not allow ASCII armor without actual payload#325
Merged
Conversation
link2xt
force-pushed
the
link2xt/filtermail-require-payload
branch
from
4c71ada to
ace59cf
Compare
missytake
force-pushed
the
link2xt/filtermail-require-payload
branch
from
ace59cf to
c3b4ecb
Compare
missytake
approved these changes
Jun 19, 2024
Comment on lines
+179
to
+185
| payload = """-----BEGIN PGP MESSAGE-----\r | ||
| \r | ||
| =njUN | ||
| -----END PGP MESSAGE-----\r | ||
| \r | ||
| """ | ||
| assert check_armored_payload(payload) == False |
Contributor
There was a problem hiding this comment.
What about this?
-----BEGIN PGP MESSAGE-----\r
\r
-----END PGP MESSAGE-----\r
or this?
-----BEGIN PGP MESSAGE-----\r
-----END PGP MESSAGE-----\r
hpk42
approved these changes
Jul 3, 2024
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
changelog would be nice but also it's minor.
Last line is removed as "optional checksum", so it can contain anything. Make sure that there is at least some actual payload besides this line.
link2xt
force-pushed
the
link2xt/filtermail-require-payload
branch
from
c3b4ecb to
f3e10cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last line is removed as "optional checksum",
so it can contain anything.
Make sure that there is at least some actual payload besides this line.