cmdeploy: skip warnings only in pyinfra 3; pyinfra crashes otherwise#378
Merged
cmdeploy: skip warnings only in pyinfra 3; pyinfra crashes otherwise#378
Conversation
Contributor
|
We are not testing with pyinfra 2, so I think everyone should update instead. Maybe print a better error message telling to upgrade, but trying to support pyinfra 2 without actually testing it is not a good idea IMO. |
Contributor
|
yip, lets just require pyinfra3 |
hpk42
approved these changes
Jul 27, 2024
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
could use a small changelog entry (which is what operators read)
hpk42
force-pushed
the
pyinfra-version-sensitivity
branch
from
a17ebec to
204756f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #376