Conversation
missytake
force-pushed
the
cmdeploy-dns-all-425
branch
from
68ec018 to
1a750d7
Compare
missytake
force-pushed
the
cmdeploy-dns-all-425
branch
from
1a750d7 to
477a5ab
Compare
hpk42
reviewed
Dec 19, 2024
hpk42
approved these changes
Dec 19, 2024
Contributor
hpk42
left a comment
hpk42
left a comment
There was a problem hiding this comment.
lgtm -- but we should test more of the CLI and return codes. There are no tests that exercise the returncode-setting currently, are there?
Contributor
Author
not that it doesn't accidentally return 0. If it returns 1 accidentally, CI will fail. |
missytake
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 88a8dc9.
missytake
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit 88a8dc9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #425