Pass through original_content instead of content in filtermail#509
Merged
Pass through original_content instead of content in filtermail#509
original_content instead of content in filtermail#509Conversation
adbenitez
approved these changes
Mar 8, 2025
link2xt
force-pushed
the
link2xt/original-content
branch
from
14b2775 to
8f2191d
Compare
missytake
reviewed
Mar 9, 2025
Contributor
missytake
left a comment
missytake
left a comment
There was a problem hiding this comment.
What kind of object is this envelope object? I can't find where this function is invoked and what is passed to it - maybe the function needs a docstring.
Contributor
Author
|
It is documented in https://aiosmtpd.aio-libs.org/en/latest/concepts.html#Envelope.original_content |
missytake
approved these changes
Mar 10, 2025
link2xt
force-pushed
the
link2xt/original-content
branch
from
8f2191d to
2e83fd0
Compare
This avoids unnecessary UTF-8 recoding and passes bytestring through.
link2xt
force-pushed
the
link2xt/original-content
branch
from
2e83fd0 to
35fe189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids unnecessary UTF-8 recoding and passes bytestring through.