feat: Improve OAuth Handling and Validation #462
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Improve OAuth Handling and Validation
Description:
This PR enhances the OAuth authentication flow in the Checkout SDK for .NET by improving token validation, refactoring OAuth models, and adding extensive test coverage.
Key Changes:
OAuth Enhancements:
New Fields in
OAuthAccessToken:TokenTypeproperty.IsValid()check to ensureTokenTypeandExpiresInare valid.Improved Token Expiration Handling:
_expirationDateis now stored in UTC.Refactored
OAuthServiceResponse:TokenTypeproperty.IsValid()now checks for empty values more strictly.Fixed OAuth Request Data Order in
OAuthSdkCredentials:grant_typebeforeclient_idin request payload for consistency.Testing Improvements:
New Unit Tests for OAuth Handling:
OAuthAccessTokenTests: Ensures tokens are correctly parsed and validated.OAuthServiceResponseTests: Validates response correctness.OAuthSdkCredentialsTests: Mocks HTTP responses and validates token retrieval.Mocked HTTP Responses:
Moq.Protectedto simulate API responses forOAuthSdkCredentials.Authorizationheader handling.Impact:
Notes:
OAuthAccessTokenandOAuthServiceResponse.