Add db connection debugging logging env#122
Merged
Merged
Conversation
rstratton
approved these changes
May 10, 2018
ziru
reviewed
May 10, 2018
| if err != nil { | ||
| if err != nil && config.Config.DBConnectionDebug { | ||
| logrus.WithField("err", err).Fatal("failed to connect to db") | ||
| } |
There was a problem hiding this comment.
It seems to me that you want config.Config.DBConnectionDebug to gate the output of err field, instead of the whole log message.
Is the change below what you intended to make?
if err != nil {
if config.Config.DBConnectionDebug {
logrus.WithField("err", err).Fatal("failed to connect to db")
} else {
logrus.Fatal("failed to connect to db")
}
}
4236ae4 to
83cd09a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the database connection error may contain credentials, we are adding this env to control whether we should log that error or not.