Add test coverage for middleware#144
Merged
Merged
Conversation
rstratton
reviewed
Jul 10, 2018
| Value: "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJmbGFncl91c2VyIjoiMTIzNDU2Nzg5MCJ9.CLXgNEtwPCqCOtUU-KmqDyO8S2wC_G6PZ0tml8DCuNw", // {"flagr_user": "1234567890"} | ||
| }) | ||
| hh.ServeHTTP(res, req) | ||
| assert.NotEqual(t, 307, res.Code) |
There was a problem hiding this comment.
Nit, might be better to assert.Equal the actual value we expect, so that tests document behavior more directly.
rstratton
reviewed
Jul 10, 2018
| req, _ := http.NewRequest("GET", "http://localhost:18000/api/v1/flags", nil) | ||
|
|
||
| incrCalled := false | ||
| monkey.PatchInstanceMethod( |
Collaborator
Author
There was a problem hiding this comment.
Yup, I was mindblown by this testing package monkey, it's so powerful that I don't even need to mock the functions. It replaces a function at runtime.
zhouzhuojie
force-pushed
the
zz/add-test-coverage-for-middleware
branch
2 times, most recently
from
b206ccd to
4068278
Compare
zhouzhuojie
force-pushed
the
zz/add-test-coverage-for-middleware
branch
from
4068278 to
9ff62e0
Compare
rstratton
approved these changes
Jul 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.