Skip to content

Use pointer cursor for flags table rows#168

Merged
zhouzhuojie merged 1 commit into
openflagr:masterfrom
marceloboeira:feature/use-pointer-cursor
Sep 23, 2018
Merged

Use pointer cursor for flags table rows#168
zhouzhuojie merged 1 commit into
openflagr:masterfrom
marceloboeira:feature/use-pointer-cursor

Conversation

@marceloboeira
Copy link
Copy Markdown
Member

Description

It looks a bit weird to not have the pointer cursor when clicking on objects that lead to actins or other pages.

For this case, clicking anywhere in the TR element, leads you to edit that flag.

Motivation and Context

UX

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

It looks a bit weird to not have the pointer cursor when clicking on
objects that lead to actins or other pages.

For this case, clicking anywhere in the TR element, leads you to edit
that flag.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #168   +/-   ##
=====================================
  Coverage      93%    93%           
=====================================
  Files          25     25           
  Lines        1330   1330           
=====================================
  Hits         1237   1237           
  Misses         63     63           
  Partials       30     30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ea2c5...3b84fc3. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @marceloboeira

@zhouzhuojie zhouzhuojie merged commit c94f055 into openflagr:master Sep 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants