Skip to content

Change Makefile#20

Merged
zhouzhuojie merged 2 commits into
masterfrom
zz/fix-circle-ci
Oct 11, 2017
Merged

Change Makefile#20
zhouzhuojie merged 2 commits into
masterfrom
zz/fix-circle-ci

Conversation

@zhouzhuojie
Copy link
Copy Markdown
Collaborator

Test CI

@zhouzhuojie zhouzhuojie force-pushed the zz/fix-circle-ci branch 6 times, most recently from c003763 to ce27cdb Compare October 10, 2017 19:09
@zhouzhuojie zhouzhuojie force-pushed the zz/fix-circle-ci branch 8 times, most recently from 33d35d9 to 125537f Compare October 11, 2017 04:22
@zhouzhuojie
Copy link
Copy Markdown
Collaborator Author

Finally get the CI working

  • Replace phantomjs with jsdom, so that it doesn't throw timeout error connecting localhost
  • Replace scss with less, so that there's no weird libsass installation issue with alpine, also it requires python, glibc, and etc.
  • Remove e2e tests, so that we don't need to handle selenium, which requires java8, and it's hard to get the dependency right.
  • other package.json fix

</script>

<style lang="scss">
<style lang="less">
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucidrains I've changed from scss to less to pass CI

@zhouzhuojie zhouzhuojie merged commit 4eca13b into master Oct 11, 2017
@zhouzhuojie zhouzhuojie deleted the zz/fix-circle-ci branch October 11, 2017 16:52
iamafanasyev pushed a commit to iamafanasyev/flagr that referenced this pull request Feb 5, 2026
Bumps [core-js](https://github.com/zloirock/core-js/tree/HEAD/packages/core-js) from 3.25.0 to 3.48.0.
- [Release notes](https://github.com/zloirock/core-js/releases)
- [Changelog](https://github.com/zloirock/core-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/zloirock/core-js/commits/v3.48.0/packages/core-js)

---
updated-dependencies:
- dependency-name: core-js
  dependency-version: 3.48.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants