Skip to content

Fix empty response when flag was deleted#213

Merged
zhouzhuojie merged 1 commit into
masterfrom
zz/fix-empty-flag-id
Feb 2, 2019
Merged

Fix empty response when flag was deleted#213
zhouzhuojie merged 1 commit into
masterfrom
zz/fix-empty-flag-id

Conversation

@zhouzhuojie
Copy link
Copy Markdown
Collaborator

Some old clients are validating flag_id in the response. If a flag was deleted, the response should still pass the flag_id >= 1 validation rule defined in swagger.

Description

Motivation and Context

How Has This Been Tested?

unit tests and integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 1, 2019

Codecov Report

Merging #213 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   86.73%   86.67%   -0.07%     
==========================================
  Files          23       23              
  Lines        1342     1343       +1     
==========================================
  Hits         1164     1164              
- Misses        127      128       +1     
  Partials       51       51
Impacted Files Coverage Δ
pkg/handler/eval.go 83.95% <0%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc964b...7d4ba27. Read the comment docs.

Copy link
Copy Markdown

@WilsonGiese WilsonGiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you 🙏

@zhouzhuojie zhouzhuojie merged commit 7ea5b99 into master Feb 2, 2019
@zhouzhuojie zhouzhuojie deleted the zz/fix-empty-flag-id branch February 2, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants