Fix empty response when flag was deleted#213
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 86.73% 86.67% -0.07%
==========================================
Files 23 23
Lines 1342 1343 +1
==========================================
Hits 1164 1164
- Misses 127 128 +1
Partials 51 51
Continue to review full report at Codecov.
|
941fd07 to
7d4ba27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some old clients are validating flag_id in the response. If a flag was deleted, the response should still pass the
flag_id >= 1validation rule defined in swagger.Description
Motivation and Context
How Has This Been Tested?
unit tests and integration tests
Types of changes
Checklist: