Use web prefix for main API#234
Merged
Merged
Conversation
5fdbb92 to
88c5da0
Compare
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 83.87% 83.76% -0.12%
==========================================
Files 24 24
Lines 1433 1435 +2
==========================================
Hits 1202 1202
- Misses 174 175 +1
- Partials 57 58 +1
Continue to review full report at Codecov.
|
michberr
approved these changes
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #225. Context is that UI's api path can be relative, and we can also prefix our main api with
FLAGR_WEB_PREFIXMotivation and Context
How Has This Been Tested?
Tested locally with and without
FLAGR_WEB_PREFIXFLAGR_WEB_PREFIX='/foo' make run
make run
Types of changes
Although breaking changes to the behavior of FLAGR_WEB_PREFIX, but the scope should be small, since it only applies to deployment after #222
Checklist: