Add EvalDebugEnabled env variable#235
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=======================================
Coverage 83.87% 83.87%
=======================================
Files 24 24
Lines 1433 1433
=======================================
Hits 1202 1202
Misses 174 174
Partials 57 57
Continue to review full report at Codecov.
|
| // Note that this is a global switch: | ||
| // if it's disabled, no evaluation debug info will be returned. | ||
| // if it's enabled, it respects evaluation request's enableDebug field | ||
| EvalDebugEnabled bool `env:"FLAGR_EVAL_DEBUG_ENABLED" envDefault:"true"` |
Member
There was a problem hiding this comment.
True as default? I would make it less intrusive ...
Collaborator
Author
There was a problem hiding this comment.
True is the current behavior. It controls globally if the server will need to respect the "enableDebug" filed from the request. https://checkr.github.io/flagr/api_docs/#operation/postEvaluation
Member
There was a problem hiding this comment.
I wasn't aware, good to know 😄
marceloboeira
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #228
Motivation and Context
Add an option so that we can disable evaluation debug globally due to security reasons. By default, it's enabled.
How Has This Been Tested?
Types of changes
Checklist: