Extend DBDRIVER to load from json_file or json_http and add EvalOnlyMode#247
Merged
Conversation
5570148 to
b57432d
Compare
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
- Coverage 82.47% 82.27% -0.2%
=========================================
Files 25 26 +1
Lines 1444 1518 +74
=========================================
+ Hits 1191 1249 +58
- Misses 193 202 +9
- Partials 60 67 +7
Continue to review full report at Codecov.
|
b57432d to
0ec160c
Compare
This was referenced Apr 22, 2019
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduced two new sources of evaluation cache.
We can leverage
FLAGR_DB_DBDRIVERandFLAGR_DB_DBCONNECTIONSTRand make flagr instances intoEvalOnlyMode, which means it will only serve traffic for/api/v1/evaluation/*. It's the first attempt to separate Flagr into data plane and control plane. AndEvalOnlyModemakes Flagr even easier to deploy with evaluation cache decoupled from the DB.This PR also introduced
SnapshotIDto flag's JSON serialization (because we need it to be included in the export, and thus json_file and json_http can load it as well)How Has This Been Tested?
Tested locally.
Types of changes
Checklist: