Add ability to output logs in JSON format#253
Merged
zhouzhuojie merged 1 commit intoMay 13, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
========================================
- Coverage 82.18% 82% -0.19%
========================================
Files 26 26
Lines 1521 1528 +7
========================================
+ Hits 1250 1253 +3
- Misses 203 207 +4
Partials 68 68
Continue to review full report at Codecov.
|
zhouzhuojie
reviewed
May 13, 2019
zhouzhuojie
approved these changes
May 13, 2019
Collaborator
zhouzhuojie
left a comment
There was a problem hiding this comment.
LGTM. Left one comment
Signed-off-by: Chris Roemmich <croemmich@myriadmobile.com>
95b9b0a to
476e43c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to use the Logrus JSONFormatter.
Motivation and Context
Allows for simple end-to-end structured logging via Docker -> Fluentd -> ElasticSearch.
How Has This Been Tested?
Tested manually. Ensured new and default behavior.
Types of changes
Checklist: