Allow more capital characters and numbers in flag keys and variant keys#257
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
=====================================
Coverage 82% 82%
=====================================
Files 26 26
Lines 1528 1528
=====================================
Hits 1253 1253
Misses 207 207
Partials 68 68
Continue to review full report at Codecov.
|
zhouzhuojie
reviewed
May 15, 2019
| b, msg = IsSafeKey(" spaces in key are not allowed ") | ||
| assert.False(t, b) | ||
| assert.NotEmpty(t, msg) | ||
| assert.NotEmpty(t, msg) |
Collaborator
There was a problem hiding this comment.
nit, there's an extra space we can remove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing capital letters and numbers in flag keys and variant keys. This helps with use cases where keys are being migrated from legacy systems to flagr.
Description
Change flag key regex to accommodate to allow any word character, digits and hyphen.
Motivation and Context
This resolves issue 254.
#254
How Has This Been Tested?
Changed unit tests and tested locally by creating keys with capital letters and digits and other combinations.
Types of changes
Checklist: