Add variant key validation and put it in the evaluation result#43
Merged
Conversation
zhouzhuojie
requested review from
epsalmond,
jasondoc3,
lucidrains and
rstratton
zhouzhuojie
force-pushed
the
zz/evaluation-return-variant-key
branch
from
826b277 to
a040f9e
Compare
rstratton
approved these changes
Oct 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strong validation around
variantKey, and also put it on evaluation results so that it's easy to SQL or Query in real-time.