Skip to content

Hint with rule name for suppression#110

Closed
Bananeweizen wants to merge 2 commits intocheckstyle:masterfrom
Bananeweizen:showSuppressionHintInMarkerProperties
Closed

Hint with rule name for suppression#110
Bananeweizen wants to merge 2 commits intocheckstyle:masterfrom
Bananeweizen:showSuppressionHintInMarkerProperties

Conversation

@Bananeweizen
Copy link
Collaborator

In the marker properties dialog have a hint showing the internal rule
name. While the human readable name is useful to locate a check in the
configuration dialog, the internal rule name is needed to create
suppression comments.

In the marker properties dialog have a hint showing the internal rule
name. While the human readable name is useful to locate a check in the
configuration dialog, the internal rule name is needed to create
suppression comments.
@Bananeweizen
Copy link
Collaborator Author

This is what it looks like:
2018-11-01_09h13_15

@romani
Copy link
Member

romani commented Nov 1, 2018

Does it make sense to make it as label ? To be reat for copy-paste ? Eclipse is very good in idea to let all information displayed be copy-able.

Suppression is done also by id of checkstyle module.

FYI: it is always better to create issue for functional changes and reference it in commit, or reference PR number in commit.

@rnveach
Copy link
Contributor

rnveach commented Nov 23, 2018

@Bananeweizen ping

@lkoe
Copy link
Member

lkoe commented Jan 22, 2019

Roman's question is still open and in my opinion he has a point. There is also sufficient space (horizontal or vertical) to show this information direction.

@romani
Copy link
Member

romani commented Jan 23, 2019

If that take that long, probably it is ok to merge this PR, hint is better than nothing.

@romani
Copy link
Member

romani commented Mar 24, 2019

@Bananeweizen, ping.
Let's finish this PR in any form, some step forward is better than no step at all

@romani
Copy link
Member

romani commented Oct 31, 2019

moved to #173 to merge as is.

@romani romani closed this Oct 31, 2019
@Bananeweizen Bananeweizen deleted the showSuppressionHintInMarkerProperties branch January 7, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants