Hint with rule name for suppression#110
Closed
Bananeweizen wants to merge 2 commits intocheckstyle:masterfrom
Closed
Hint with rule name for suppression#110Bananeweizen wants to merge 2 commits intocheckstyle:masterfrom
Bananeweizen wants to merge 2 commits intocheckstyle:masterfrom
Conversation
In the marker properties dialog have a hint showing the internal rule name. While the human readable name is useful to locate a check in the configuration dialog, the internal rule name is needed to create suppression comments.
Collaborator
Author
Member
|
Does it make sense to make it as label ? To be reat for copy-paste ? Eclipse is very good in idea to let all information displayed be copy-able. Suppression is done also by FYI: it is always better to create issue for functional changes and reference it in commit, or reference PR number in commit. |
Contributor
|
@Bananeweizen ping |
Member
|
Roman's question is still open and in my opinion he has a point. There is also sufficient space (horizontal or vertical) to show this information direction. |
Member
|
If that take that long, probably it is ok to merge this PR, hint is better than nothing. |
Member
|
@Bananeweizen, ping. |
Member
|
moved to #173 to merge as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In the marker properties dialog have a hint showing the internal rule
name. While the human readable name is useful to locate a check in the
configuration dialog, the internal rule name is needed to create
suppression comments.