Can't run eclipse checkstyle check from system not connected to internet.

[mike-jay-k]

eclipse-cs/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java

Line 98 in 768ef91

final Document document = reader.read(in);

Attempting to run checkstyle on code, from a computer that is disconnected from the internet, fails at this point in the code. I've found that if you have a web server on your localhost and import your own configuration XML with the dtd location changed to that localhost location where you've saved the dtd to, then the DTD is found and operates successfully.

Stacktrace below:

net.sf.eclipsecs.core.util.CheckstylePluginException: Remote host closed connection during handshake Nested exception: Remote host closed connection during handshake
	at net.sf.eclipsecs.core.util.CheckstylePluginException.rethrow(CheckstylePluginException.java:67)
	at net.sf.eclipsecs.core.util.CheckstylePluginException.rethrow(CheckstylePluginException.java:80)
	at net.sf.eclipsecs.core.config.ConfigurationReader.read(ConfigurationReader.java:102)
	at net.sf.eclipsecs.core.config.ConfigurationReader.getAdditionalConfigData(ConfigurationReader.java:122)
	at net.sf.eclipsecs.core.builder.CheckerFactory.getAdditionalData(CheckerFactory.java:172)
	at net.sf.eclipsecs.core.builder.Auditor.runAudit(Auditor.java:145)
	at net.sf.eclipsecs.core.builder.CheckstyleBuilder.handleBuildSelection(CheckstyleBuilder.java:306)
	at net.sf.eclipsecs.core.jobs.RunCheckstyleOnFilesJob.runInWorkspace(RunCheckstyleOnFilesJob.java:119)
	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:39)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:60)
Caused by: org.dom4j.DocumentException: Remote host closed connection during handshake Nested exception: Remote host closed connection during handshake
	at org.dom4j.io.SAXReader.read(SAXReader.java:484)
	at net.sf.eclipsecs.core.config.ConfigurationReader.read(ConfigurationReader.java:98)
	... 7 more

[rnveach]

@mikeisgo What is the top portion of your configuration, which specifies the dtd, that eclipse-cs is using?

It's possible eclipse-cs is missing some DTDs from checkstyle and that is why it is connecting to the internet to get it.
Eclipse-CS:
https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java#L62-L73
Checkstyle:
https://github.com/checkstyle/checkstyle/blob/master/src/main/java/com/puppycrawl/tools/checkstyle/ConfigurationLoader.java#L75-L120

[mike-jay-k]

I'm using the currently available 8.12.0 version downloadable from the Eclipse Marketplace, and the stacktrace i posted is from eclipse when it errors out. I'm not compiling my own plugin, so I'd assume the https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java#L62-L73
link you provided is the top configuration used in that plugin. I believe the 8.12.0 tag of the codebase shows that same list of DTDs. I would assume the same thing that the locally provided DTDs are compiled into the plugin for the 1_3 version.

The checks xml file I'm using prescribes the following:

<!DOCTYPE module PUBLIC
          "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
          "https://checkstyle.org/dtds/configuration_1_3.dtd">

Which is from this file: https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml

[rnveach]

The DTD map in eclipse CS is not correct.

https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.core/src/net/sf/eclipsecs/core/config/ConfigurationReader.java#L72

-//Checkstyle//DTD Check Configuration 1.3//EN

This should be -//Checkstyle//DTD Checkstyle Configuration 1.3//EN. It is missing the 2nd Checkstyle and just has Check instead. This is why it is requiring internet connection to find the right DTD.

[ywang271828]

Have the fix been uploaded to the eclipse market place build? I just installed the 8.0.12 from Eclipse market place and had the same error here.

[rnveach]

Nothing has been released in almost 1 year for eclipse-cs.