New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly catch EPROTOTYPE on macOS #44

Merged
merged 1 commit into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@Safihre
Contributor

Safihre commented Aug 9, 2017

@webknjaz @The-Compiler
A helpful user that got this error a lot debugged this for me.
cheroot.errors.plat_specific_errors('EPROTOTYPE') produces an array, so appending an array to an array gives...

socket_errors_nonblocking = [35, [41]]

So seems to me the original patch never worked either?

@The-Compiler

This comment has been minimized.

Contributor

The-Compiler commented Aug 9, 2017

Oh, my bad... I think you're right, in retrospective I'm not sure how this ever could've worked 😊

@webknjaz

This comment has been minimized.

Member

webknjaz commented Aug 9, 2017

I wish there were tests for this error handling

@webknjaz webknjaz merged commit 547e254 into cherrypy:master Aug 9, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment