fix(formatDate): prevent sequential replacements from corrupting month/weekday names #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Rewrote formatDate using a proper token-based parser instead of sequential .replace() calls. The old approach corrupted month/weekday names (e.g., "March" became "Marc10" because 'h' was replaced by the hour value). Changes: - Use single-pass regex tokenizer that matches tokens by priority (longest first) - Add support for Moment.js-style escape syntax [...] for literal text - Non-token characters pass through unchanged - Add comprehensive test suite with 72 tests covering: - All token types (year, month, day, weekday, time, AM/PM) - Sequential replacement corruption scenarios - Escape syntax edge cases - Stress tests across all month/hour/minute combinations
chhoumann
force-pushed
the
fix/formatDate-sequential-replacement-corruption
branch
from
958ecf5 to
c933b40
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
# [2.15.0](2.14.3...2.15.0) (2025-11-24) ### Bug Fixes * add setter for playbackRate binding to prevent runtime error ([992c0cc](992c0cc)) * artwork image now fills full container size ([1407209](1407209)) * detach leaves on plugin unload to prevent duplicate views ([692279d](692279d)) * **FeedParser:** fix metadata handling and add tests ([a30eca1](a30eca1)) * fix crash when navigating away from Latest Episodes during fetch ([9e8cd18](9e8cd18)) * **formatDate:** rewrite with token parser to prevent corruption ([#157](#157)) ([3b2dcac](3b2dcac)) * guard obsidian inputs from feedback loops ([#154](#154)) ([2d8b5c5](2d8b5c5)) * mount views with svelte api ([#134](#134)) ([f2d6e80](f2d6e80)) * move chapter fetching from reactive block to subscription ([9d67c41](9d67c41)) * performance overhaul to prevent crashes ([30a5a0a](30a5a0a)) * persist hide-played toggle ([#144](#144)) ([732f094](732f094)) * playlist card sizing to properly contain icon and count text ([ff18fbc](ff18fbc)) * podcast grid now scrolls properly ([2965af2](2965af2)) * **TranscriptionService:** fix bugs and add tests ([fb20e25](fb20e25)) * use get() for store access inside async functions ([8a20a33](8a20a33)) ### Features * add podcast chapter support ([d10eeb7](d10eeb7)) * add timestamp offset setting ([#131](#131)) ([46c4d4b](46c4d4b)) * style improvements ([f566bc9](f566bc9))
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
formatDateusing a proper token-based parser instead of sequential.replace()callsformatDate(date, 'MMMM')returned "Marc10" instead of "March" because 'h' was replaced by the hour value)[...]for literal textTest plan
formatDate(new Date('2024-03-01T10:00:00'), 'MMMM')returns "March" (not "Marc10")[literal text]works correctlyNew test coverage