feat(mixins): add iter_all to PaginationMixin #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbr-chift
changed the title
hhertoghe
reviewed
Jun 17, 2025
Contributor
hhertoghe
left a comment
hhertoghe
left a comment
There was a problem hiding this comment.
Few comments, thanks , looks good to me globally, I've asked Florian to take a look as well.
I guess we should only user iter_all in syncs when we know that we do not need to retrieve everything first ?
Makes it possible to iterate through a Generator instead of having to load all data in memory when calling all.
Adds the necessary overload to cover the different types of returns covered from our different mixins.
wbr-chift
force-pushed
the
williambraeckman/bac-284-optimize-sync-ecommerce
branch
from
41e5429 to
fdeebcf
Compare
Contributor
Author
|
@hhertoghe @grasflorian should be good |
hhertoghe
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to iterate through a Generator instead of having to
load all data in memory when calling all.