-
-
Couldn't load subscription status.
- Fork 2
Remove Multi-Application support from HTTP registration #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Multi-Application support from HTTP registration #43
Conversation
|
Preliminary into what can go to xml |
|
Gonna try and pick this up once more tomorrow hopefully. |
75584d9 to
5aed642
Compare
|
Rebased on 0.4.0 Let's pair later to understand what else we want to do and remove the scaffolding. |
|
From research these are the services i see being used by name/alias:
Parameters:
Replacing all with a Class reference is welcome, its just BC so we need to decide how to handle deprecating it. |
5aed642 to
ebe9d13
Compare
|
I've just rebased this on top of 0.5.x... I'll apply the changes to the Mezzio implementation so we can rely on the functional tests to make sure we don't break stuff and to say "buh bye" to Expressive. |
In order to simplify the container generation process, let's stop allowing the registration of multiple apps in a container and stick to a single one. A side effect of these changes is that we can statically create the XML files for the services created in the compiler passes. We looked into it but we couldn't do it in a time-efficient manner.
ebe9d13 to
1f3534a
Compare
All service Ids that use ApplicationName are now replaced with the proper class or interface, and an alias is set to the previous name.
1f3534a to
5de5fd5
Compare
Making sure everything still works as expected on the functional tests.
The Expressive implementation is getting in the way of keeping a sane amount here. We'll review these requirements once the deprecated component is removed.
5de5fd5 to
1334575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reorganised a few things here and there and made the test suite pass with the Mezzio implementation.
The current failures will be fixed in another PR (as remove zend expressive and upgrade dependencies).
|
I'll merge this so we can continue the clean-up. |
Alright, taking previous work further, opening this as a Draft to start validating steps.
For now I isolated all definition creation to use the class/interface and add an alias to the previous name based on
applicationName.Next up I'll look what is static enough to be extracted to an XML.
For reference: