Skip to content

Conversation

@alexd-codaio
Copy link

Added an option for printing the logging statements since they are filling up my production logs and test runs.

Please take a look when you get a chance @chimurai

@chimurai
Copy link
Owner

Thanks for the pull request @adeneui

I was actually working on this issue on the logger branch.
Had a feeling the console.log statements would start to itch someone sooner or later :)

What I had in mind was actually a more flexible setup.
I created two issues to share my thoughts.

#26: Allows you to control the logging levels. You'll be able to disable logging, but it will also allow you to log everything. This might be handy for debugging purposes.

#27: Allows you to set your own log provider, such as winston or log4js. This should greatly enhance the logging abilities. (Write log statements to file or database, etc...)

I hope the proposed setup will fit the needs of many.
Let me know what you think and feel free to comment.

@alexd-codaio
Copy link
Author

Sounds good to me. Do you have an idea of which one you would prefer (since they seem somewhat orthogonal)? I can refactor this PR to accommodate #26 without much hassle.

@chimurai
Copy link
Owner

I prefer the logger branch. It will implement #26 and #27.
The included tests should prevent regression in the logging functionality.

It's almost ready to be merged back.

@mpareja
Copy link

mpareja commented Sep 25, 2015

+1
We throw JSON logs at ElasticSearch and it gets upset when the input isn't in the JSON format it's expecting.

@chimurai
Copy link
Owner

Closing PR.
Functionality is implemented in #30

@chimurai chimurai closed this Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants