-
Notifications
You must be signed in to change notification settings - Fork 876
Hook into http-proxy onProxyReq #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also opens up logging the proxied request. ;) |
|
Thanks for the PR. You should already be able to set the request headers with Could you document the The code coverage dropped significantly. I think it's caused by Lastly, could you squash you commits to keep the commits clean? With these changes, this PR looks fit to be merged. :) |
|
got the chance to update the pull request so it can be merged? |
|
I got so busy that I forgot about it. I'll do it today. ;) |
|
Great! Looking forward to it :) |
|
Any luck to update this PR? I was hoping to include this on the next release. Otherwise I'll postpone this PR to a later release. Mean concerns are the dropped code coverage and the documentation of the new option. |
|
My apologies. Life has had me busy and I totally spaced it. I can get on it right now. |
|
and there she is! 👍 |
|
dang it |
|
I should've used a feature branch. Sorry for this. |
|
finally. So sorry. |
|
crap. haha. |
|
Dude. I've made a mess. I went one commit too far. It includes your notes. |
|
If this is a no-go, you can delete this PR and I'll create a new one. |
|
A new PR would be nice, if it isn't too much effort. |
|
Closing PR. |
I need to be able to setHeader