fix: robust eask install-deps error handling#9
Merged
Conversation
- Handle exit code 2 (no deps to install) gracefully instead of failing - Add explicit shell: bash for cross-platform consistency - Add comments explaining Nix cache is needed by setup-emacs on Linux Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the CI workflow by handling edge cases in dependency installation and adding documentation for Nix-related steps.
Changes:
- Modified
eask install-depsto gracefully handle exit code 2 (no dependencies to install) instead of failing - Added explicit
shell: bashfor cross-platform compatibility with bash-specific syntax - Added inline comments explaining Nix cache steps are required by
setup-emacson Linux
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eask install-depsexit code 2 (no deps to install) gracefully instead of failing the jobshell: bashfor cross-platform consistencyjcs090218/setup-emacson LinuxBrings space-tree CI in line with brushup's CI setup.
Test plan
Generated with Claude Code