Skip to content

brd value change to uint32 #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

brd value change to uint32 #105

wants to merge 4 commits into from

Conversation

@gillespilloudkerlink
Copy link
Contributor

@gillespilloudkerlink gillespilloudkerlink commented Mar 5, 2019

use uint32 instead of uint8 for Board values.

@gillespilloudkerlink
Copy link
Contributor Author

gillespilloudkerlink commented Mar 5, 2019

in reference of #104 issue

@brocaar
Copy link
Collaborator

brocaar commented Mar 5, 2019

Thank @gillespilloudwyres

  • You mentioned that the Protobuf Board field is of type uint32. In that case you don't have to cast the fields (e.g. Brd: uint32(frame.TxInfo.Board) could simply be Brd: frame.TxInfo.Board).
  • Could you install a Go plugin for your editor? That will (usually) automatically format the source-code 🙂 E.g. for VSCode there is: https://github.com/Microsoft/vscode-go. This is not a big issue, but it helps to keep the code formatted.

brocaar added a commit that referenced this pull request Mar 7, 2019
@brocaar
Change Brd from uint8 to uint32.
82adc02 
Some packet-forwarders encode more information in this field and
therefore require require an uint32 type instead of uint8.

Closes #104 and #105. Thanks @gillespilloudwyres.
@brocaar
Copy link
Collaborator

brocaar commented Mar 7, 2019

I've merged your pull-request with one change (in the legacy code, it had to be casted to an int): 82adc02.

@brocaar brocaar closed this Mar 7, 2019
@brocaar
Copy link
Collaborator

brocaar commented Mar 7, 2019

Will release this as v2.7.1 and will also create packages for the Kerlink gateways: https://www.loraserver.io/lora-gateway-bridge/gateway/kerlink/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gillespilloudkerlink @brocaar