Fix corrupted gateway statistics for downlink packets. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lglenat
commented
Nov 2, 2018
| TxPacketsEmitted: p.Payload.Stat.RXFW, | ||
| TxPacketsReceived: p.Payload.Stat.TXNb, | ||
| TxPacketsEmitted: p.Payload.Stat.TXNb, | ||
| TxPacketsReceived: p.Payload.Stat.DWNb, |
Contributor
Author
There was a problem hiding this comment.
This is where the bug is. I checked there is no bug in the internal/legacy/gateway stuff.
lglenat
force-pushed
the
patch/gatewayStatsDownlinkPackets
branch
from
c6fb770 to
7297150
Compare
|
Great spot! |
Collaborator
|
Great spot indeed and thanks for your fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the mapping between what's received from the Semtech Packet Forwarder over UDP and the Gateway Bridge stats.
Addresses https://forum.loraserver.io/t/rxpacketsreceived-ok-counter/2687