Lazy types, (SwiftUI) improvements #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

chris-swift-dev merged 54 commits into master from dev

May 1, 2021

Owner

chris-swift-dev commented Apr 19, 2021

No description provided.

Christian Elies and others added 9 commits

February 13, 2021 23:01


          Merge branch 'master' into dev

414625d


          feat(photo): added target size parameter to photo.view, show activity…

ca884e5

… indicator view while loading photo; refactor(photo): improved implementation, added state machine; refactor(video): improved implementation; feat(video): added activity indicator view to video.view


          feat(video): added preview image API; fix(video view): fixed item to …

…player connection issue


          fix(video view): fixed latest os player implementation

83e109c


          refactor(): refactored and improved camera view and live photo view

af0183c


          feat(): implemented lazy types

64216d4


          feat(lazy): implemented more lazy APIs, improved existing lazy APIs

14a85c6


          fix(media): implemented latest permission API changes

26dffa0


          fix(media): dispatch request permission completion block to main queu…

239c64c

…e; feat(media): request camera permission

chris-swift-dev changed the title ~~Improvements, especially SwiftUI~~ Lazy types, (SwiftUI) improvements

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Album/LazyAlbum.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Album/LazyAlbums.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Audio/LazyAudio.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Audio/LazyAudios.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/LivePhoto/LazyLivePhoto.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/LivePhoto/LazyLivePhotos.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Media/Media.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Media/Media.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Media/Media.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Photo/LazyPhoto.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Photo/LazyPhotos.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Video/LazyVideo.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Video/LazyVideos.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Video/Video.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaCore/API/Media/Media.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaSwiftUI/API/Photo/Photo+SwiftUI.swift Outdated Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaSwiftUI/internal/Views/LivePhoto/LivePhotoView.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaSwiftUI/internal/Views/Photo/PhotoView.swift Show resolved Hide resolved

chris-swift-dev commented

View reviewed changes

Sources/MediaSwiftUI/internal/Views/Video/VideoView.swift Show resolved Hide resolved


          added missing API documentation, fixed tests

ff53016

Christian Elies added 4 commits

April 22, 2021 00:28


          fix(lazy album): use anonymous uuid as id

d097621


          added code comment

b9decc9


          use ph asset fetcher in lazy album, implemented lazy album tests

0d83a3c


          removed unnecessary permission check, implemented lazy types tests

69732ce

chris-swift-dev commented

View reviewed changes

Owner Author

chris-swift-dev left a comment

.

Christian Elies added 24 commits

April 30, 2021 23:30


          docs(readme): added examples section

7c68e10


          docs(readme): added hints to the new lazy containers

0d93ffd


          refactor(av player view): small improvements

a67312e


          chore(example): improved identifiable

049c1b6


          feat(lazy containers): now conform to identifiable

db2ba8a


          chore(example): fixed bugs in lazy tree item implementation

f69cf3e


          chore(example): show creation date in lazy tree item if present

e45912a


          chore(example): splitted lazy example views from default example views

b03a147


          docs(lazy albums): added warning

280d1f6


          chore(example): readded none lazy examples

c8f6d7f


          chore(example): readded more none lazy examples

5be740e


          chore(example): added none lazy video examples

61647fc


          chore(example): added section header, regrouped sections, created sep…

3496edb

…arate file for section, small improvements


          feat(swiftui): make use of PHPicker on iOS 14 and macOS 11 and allow …

56552b8

…multi selection in browsers, replaced throwing with presenting a SwiftUI.Text by default with the option to provided a view builder to present a custom error view


          chore(example): updated examples

1008f11


          docs(swiftui): updated API documentation

c88e840


          docs(readme): added selectionLimit parameter

47eb5b5


          docs(swiftui): improved API documentation

0ef86c0


          refactor(swiftui): readded media type

234b9b7


          fix(swiftui): added missing parameter

80ce977


          feat(media): current camera permission; docs(readme): updated README

106e77e


          chore(example): implemented limited library access selection view exa…

1e11d52

…mple


          chore(example): show current permission state in permissions section

2e6d683


          chore(example): allow multi selection in browser views

d87b041

chris-swift-dev merged commit 1888e4a into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet