Fixes the issue of handling NaN/None by using pandas Series in an optimized way. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@BertrandBordage Looks like we're having problems with Python 3 |
Contributor
Author
|
Oops… this should be fixed now. |
chrisdev
added a commit
that referenced
this pull request
May 27, 2014
Fixes the issue of handling NaN/None by using pandas Series in an optimized way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I was struggling with: sometimes the pk list is a series of floats (when there are NaN values), and sometimes it's just a series of int. If it's a series of int, checking whether a pk is NaN raises a TypeError.
After digging, I figured that would be easier to use pandas Series to handle all this. I made a lot of timeits to find the fastest algorithm I could do without having to use Cython.
It shouldn't be faster however, just as fast as before (when it was buggy).